Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12318/2/src/osysmon_ctrl.c File src/osysmon_ctrl.c: https://gerrit.osmocom.org/#/c/12318/2/src/osysmon_ctrl.c@25 PS2, Line 25: #include <stdio.h> Why is this one needed? Doesn't seem related to the patch. https://gerrit.osmocom.org/#/c/12318/2/src/simple_ctrl.c File src/simple_ctrl.c: https://gerrit.osmocom.org/#/c/12318/2/src/simple_ctrl.c@53 PS2, Line 53: static void ctrl_cfg_printf(const struct ctrl_cfg *cfg, const char *fmt, ...) Having this instead of a macro looks overkill to me, but fine. -- To view, visit https://gerrit.osmocom.org/12318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I788d51359965a66c54075a3971aa7824c3bfb0bf Gerrit-Change-Number: 12318 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Thu, 20 Dec 2018 15:45:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
