Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12404 )
Change subject: err log: fully log MS supported A5 algos on mismatch ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12404/4/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/12404/4/src/libmsc/gsm_04_08.c@121 PS4, Line 121: static const char *classmark_a5_name(const struct gsm_classmark *cm) could make sense to have this in libosmocore rather than here, but not a strict requirement. -- To view, visit https://gerrit.osmocom.org/12404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb18e0f0bb420de066e7eb8fc683f192ba2a7368 Gerrit-Change-Number: 12404 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 03 Jan 2019 16:08:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
