Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c File src/msgb.c: https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c@253 PS1, Line 253: LOGPSRC(DLGLOBAL, LOGL_FATAL, file, line, Why is this line not guarded by "print" variable? https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c@263 PS1, Line 263: LOGPC(DLGLOBAL, LOGL_FATAL, " msgb %s\n", osmo_hexdump(m_data, len)); Why is this line not guarded by "print" variable? At least before it was supposed to print NULL and not call osmo_hexdump() before if not needed. -- To view, visit https://gerrit.osmocom.org/12484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24dc3fad6f64ef788da9b7d790f9d5f689190c42 Gerrit-Change-Number: 12484 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Jan 2019 17:04:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
