osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12490 )

Change subject: Cosmetic: hlr.c: remove confusing indent below if
......................................................................

Cosmetic: hlr.c: remove confusing indent below if

Remove a misleading block in rx_upd_loc_req() around the call to
lu_op_tx_insert_subscr_data(). At least for me, this made the block look
like it belonged to the if statement above (which has no brackets),
before I looked more closely at it.

Change-Id: I96d3ba4108f4811279caf088a9179afce24e8112
---
M src/hlr.c
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/hlr.c b/src/hlr.c
index ce5618a..614e99f 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -330,13 +330,12 @@
                LOGP(DAUC, LOGL_ERROR, "IMSI='%s': Cannot update %s in the 
database\n",
                     subscr->imsi, luop->is_ps ? "SGSN number" : "VLR number");

-       {
-               /* TODO: Subscriber allowed to roam in PLMN? */
-               /* TODO: Update RoutingInfo */
-               /* TODO: Reset Flag MS Purged (cs/ps) */
-               /* TODO: Control_Tracing_HLR / Control_Tracing_HLR_with_SGSN */
-               lu_op_tx_insert_subscr_data(luop);
-       }
+       /* TODO: Subscriber allowed to roam in PLMN? */
+       /* TODO: Update RoutingInfo */
+       /* TODO: Reset Flag MS Purged (cs/ps) */
+       /* TODO: Control_Tracing_HLR / Control_Tracing_HLR_with_SGSN */
+       lu_op_tx_insert_subscr_data(luop);
+
        return 0;
 }


--
To view, visit https://gerrit.osmocom.org/12490
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I96d3ba4108f4811279caf088a9179afce24e8112
Gerrit-Change-Number: 12490
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>

Reply via email to