Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12485 )
Change subject: LCLS: constify helper parameters ...................................................................... Patch Set 1: Code-Review-1 (1 comment) looks good except that one const there https://gerrit.osmocom.org/#/c/12485/1/src/osmo-bsc/osmo_bsc_lcls.c File src/osmo-bsc/osmo_bsc_lcls.c: https://gerrit.osmocom.org/#/c/12485/1/src/osmo-bsc/osmo_bsc_lcls.c@278 PS1, Line 278: static void lcls_break_local_switching(const struct gsm_subscriber_connection *conn) the function changes the switching of the conn, right? Isn't it confusing to say const then? -- To view, visit https://gerrit.osmocom.org/12485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I341f4ea172432b94e8e96919926a5fb6870c2a30 Gerrit-Change-Number: 12485 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:32:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
