Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12538
Change subject: Don't send SMS STATUS REPORT locally if the ESME accepted it. ...................................................................... Don't send SMS STATUS REPORT locally if the ESME accepted it. Backport of https://gerrit.osmocom.org/11792/ When using smpp-first, after the ESME accepts our STATUS REPORT, we were sending it locally into gsm340_rx_sms_submit() anyway. In the case of the ESME mirroring the report back to us, this would result in two copies of the status report in the SMS database, which were also both then delivered to the MS. Some MS then display the REPORT to the user as if it were a normal SMS. With this patch, we check if it is the sms_report that has had receiver set in sms_route_mt_sms() and not the original SMS we are reporting on, which of course already has receiver set. Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2 --- M openbsc/src/libmsc/gsm_04_11.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/38/12538/1 diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c index 25ef487..d5619b2 100644 --- a/openbsc/src/libmsc/gsm_04_11.c +++ b/openbsc/src/libmsc/gsm_04_11.c @@ -697,7 +697,7 @@ } /* No route via SMPP, send the GSM 03.40 status-report now. */ - if (gsms->receiver) + if (sms_report->receiver) gsm340_rx_sms_submit(sms_report); LOGP(DLSMS, LOGL_NOTICE, "Status report has been sent\n"); -- To view, visit https://gerrit.osmocom.org/12538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2136489bd21c4755463278a4048a446e5bc4a9d2 Gerrit-Change-Number: 12538 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]>
