Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12527 )

Change subject: VTY: integrate IMEI
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12527/7/src/hlr_vty_subscr.c
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/#/c/12527/7/src/hlr_vty_subscr.c@62
PS7, Line 62: IMEI
I don't know, are there any benefits of storing IMEI without the checksum in 
the DB, but maybe we should at least print the full IMEI with 15th digit (i.e. 
pre-calculate it)?



--
To view, visit https://gerrit.osmocom.org/12527
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
Gerrit-Change-Number: 12527
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-CC: Max <msur...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jan 2019 11:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to