Max has uploaded this change for review. ( https://gerrit.osmocom.org/12615
Change subject: Log transaction allocation errors as such ...................................................................... Log transaction allocation errors as such While at it, use proper subsystem to log missing VLR subscriber. Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9 --- M src/libmsc/gsm_04_08_cc.c M src/libmsc/gsm_09_11.c M src/libmsc/transaction.c 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/12615/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 7172184..0119e7b 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -1931,7 +1931,7 @@ /* Create transaction */ trans = trans_alloc(net, vsub, GSM48_PDISC_CC, 0xff, data->callref); if (!trans) { - DEBUGP(DCC, "No memory for trans.\n"); + LOGP(DCC, LOGL_ERROR, "No memory for trans.\n"); vlr_subscr_put(vsub); /* Ressource unavailable */ mncc_release_ind(net, NULL, data->callref, @@ -2129,7 +2129,7 @@ GSM48_PDISC_CC, transaction_id, new_callref++); if (!trans) { - DEBUGP(DCC, "No memory for trans.\n"); + LOGP(DCC, LOGL_ERROR, "No memory for trans.\n"); rc = gsm48_tx_simple(conn, GSM48_PDISC_CC | (transaction_id << 4), GSM48_MT_CC_RELEASE_COMPL); diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 12bec9d..608d4ff 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -101,7 +101,7 @@ trans = trans_alloc(conn->network, conn->vsub, GSM48_PDISC_NC_SS, tid, new_callref++); if (!trans) { - DEBUGP(DMM, " -> No memory for trans\n"); + LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n"); gsm48_tx_simple(conn, GSM48_PDISC_NC_SS | (tid << 4), GSM0480_MTYPE_RELEASE_COMPLETE); @@ -298,7 +298,7 @@ trans = trans_alloc(net, vsub, GSM48_PDISC_NC_SS, 0xff, gsup_msg->session_id); if (!trans) { - DEBUGP(DMM, " -> No memory for trans\n"); + LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n"); return NULL; } diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index df770ed..17f8e96 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -109,7 +109,7 @@ /* a valid subscriber is indispensable */ if (vsub == NULL) { - LOGP(DCC, LOGL_NOTICE, + LOGP(DVLR, LOGL_ERROR, "unable to alloc transaction, invalid subscriber (NULL)\n"); return NULL; } -- To view, visit https://gerrit.osmocom.org/12615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9 Gerrit-Change-Number: 12615 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de>