Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12622 )
Change subject: lchan_select: dont allow half rate EFR to be selected ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@140 PS1, Line 140: EFR works over FR channels only */ > This comment looks confusing. Let's rather say: […] agree https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@142 PS1, Line 142: return NULL; /* fall through */ https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@143 PS1, Line 143: /* fall through */ > Please add some "fall-through" comment here to suppress Coverity / compiler > warnings. ack. it's fine to omit a comment below GSM48_CMODE_SPEECH_V1, but above it you need to add a "/* fall through */" comment. -- To view, visit https://gerrit.osmocom.org/12622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8 Gerrit-Change-Number: 12622 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 21 Jan 2019 13:56:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
