osmith has posted comments on this change. ( https://gerrit.osmocom.org/12527 )
Change subject: VTY: integrate IMEI ...................................................................... Patch Set 12: (1 comment) https://gerrit.osmocom.org/#/c/12527/10/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/#/c/12527/10/src/hlr_vty_subscr.c@62 PS10, Line 62: if (*subscr->imei) { > Is this necessary? This can only happen if the user modified the SQL db file > directly without osmo-h […] As discussed in the chat, the check above is implemented now - together with a test case. -- To view, visit https://gerrit.osmocom.org/12527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30 Gerrit-Change-Number: 12527 Gerrit-PatchSet: 12 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jan 2019 14:06:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
