Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12401 )
Change subject: fix lchan modifications: switch off re-using lchan during assignment ...................................................................... Patch Set 3: (1 comment) I'm annoyed that this patch is still here a month later. For me it is so obviously necessary to disable that phony lchan re-use code, because it so obviously cannot work. And since obviously assigning a new lchan *does* work, the re-use attempt is just not useful. We are not going to fix the re-use at the moment, so there is one trivial way to fix the two scenarios explained: don't try to re-use the lchan! I would welcome to get over this now. If the way to merge this is to shift explanations around from code comments to issue tracker, I can do that, but I don't see a benefit. https://gerrit.osmocom.org/#/c/12401/3/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/12401/3/src/osmo-bsc/assignment_fsm.c@369 PS3, Line 369: Test scenario: > This looks like it belong to TTCN3 instead. […] unfortunately I can't spend time on that now -- To view, visit https://gerrit.osmocom.org/12401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 23 Jan 2019 11:35:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
