osmith has posted comments on this change. ( https://gerrit.osmocom.org/12760 )
Change subject: Stream client: fix disconnection logic ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12760/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12760/1//COMMIT_MSG@9 PS1, Line 9: Previously closing the client did not alter it's state so might end-up : with a client without any file descriptors but in : STREAM_CLI_STATE_CONNECTED. Fix this inconsistency by setting : appropriate state. This sentence is a bit hard to read. How about: "Previously closing the client did not alter its state, so we might end-up with a client without any file descriptors, but being in state STREAM_CLI_STATE_CONNECTED." (it's -> its, added commas, inserted "we" and "being in state") https://gerrit.osmocom.org/#/c/12760/1//COMMIT_MSG@14 PS1, Line 14: (missing comma) -- To view, visit https://gerrit.osmocom.org/12760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e Gerrit-Change-Number: 12760 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jan 2019 14:41:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
