Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12901 )
Change subject: transaction: clarify magic 0xff transaction ID ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12901/2/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/12901/2/src/libmsc/gsm_04_11.c@1044 PS2, Line 1044: /* According to 8.2.3, MR is in the range 0 through 255 */ > That kinda looks suspicious as well: it's not clear from the comment whether > 255 is included in the […] The "... in the range 0 through 255" comes from the specs. as is. As far as I understand, 0xff is also a valid value, but I don't think a subscriber can reach such value. Even in case of the multi-part SMS, when each part has a unique Message Reference. The current code does limit the amount of parts to 255. How often do you send SMS messages consisting of 256 parts? ;) In case of OTA messages, I don't think a regular SIM has such amount of RAM available. -- To view, visit https://gerrit.osmocom.org/12901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d3a6334f49989bedbb1430d26ffad8b61dfd873 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 19:09:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
