Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12880 )
Change subject: add OSMO_STRBUF_PRINTF() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12880/2/include/osmocom/core/utils.h File include/osmocom/core/utils.h: https://gerrit.osmocom.org/#/c/12880/2/include/osmocom/core/utils.h@153 PS2, Line 153: size_t len; > the members might need a quick comment, at least the len_needed isn't > immediately obvious. oh shucks, I forgot to push the new patch set I made which contains lots more comments -- To view, visit https://gerrit.osmocom.org/12880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2 Gerrit-Change-Number: 12880 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Fri, 15 Feb 2019 03:03:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
