Max has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 12: (1 comment) https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c@635 PS8, Line 635: switch (ct->ch_rate_type) { > I can of course change it but I am not sure if this is wise, we might break > the backward compatibility of the API. You can always add wrapper to libosmocore's src/gsm/gsm0808_utils.c to avoid dealing with gsm0808_chan_rate_type_speech values/masking directly. This would hide the odd naming until we can deprecate it properly. It'd also help with documenting/clarifying that naming confusion. -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Assignee: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: tnt <t...@246tnt.com> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 21 Feb 2019 09:52:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
