Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13064 )
Change subject: MCS: move Coding Scheme enum to C header ...................................................................... Patch Set 1: the code you're touching is undoubtedly C++ code. I'm not sure if it's an improvement to turn [more] parts of it into C. Also, I don't see from your changes or from the commitlog *why* this simplifies testing. It's not clear that C++ can be tested less than C ?1? -- To view, visit https://gerrit.osmocom.org/13064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I993b49d9a82b8c7ad677d52d11003794aeabe117 Gerrit-Change-Number: 13064 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:41:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
