Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13057 )
Change subject: Use boolean for DL resegmentation parameter ...................................................................... Patch Set 1: there is no downlink arq type "true" or "false". While I agree i fthere are only two discrete values you should use a type with only two options, but if those optionsare not something that can be "true" or "false", using bool is just as wrong as using int, isn't it? -- To view, visit https://gerrit.osmocom.org/13057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476 Gerrit-Change-Number: 13057 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 26 Feb 2019 23:10:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No