Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13016 )
Change subject: libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference
......................................................................
libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference
The SGS_STATE_TS11 is not for counters, it's for timers!
Change-Id: Ifbb1a37e644ae8bf8e7959f6f6cd6403ac1f2f1b
Fixes: CID#190872 Out-of-bounds read (OVERRUN)
---
M src/libmsc/sgs_iface.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, approved
Max: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 1c2146a..4f262a5 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -1129,7 +1129,7 @@
mme->ns11_remaining--;
} else {
LOGMME(mme, LOGL_ERROR, "Ts11 expired more than %u
(Ns11) times, giving up\n",
- sgs->cfg.counter[SGS_STATE_TS11]);
+ sgs->cfg.counter[SGS_STATE_NS11]);
osmo_fsm_inst_state_chg(fi, SGS_VLRR_ST_NULL, 0, 0);
}
break;
--
To view, visit https://gerrit.osmocom.org/13016
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbb1a37e644ae8bf8e7959f6f6cd6403ac1f2f1b
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
