Max has posted comments on this change. ( https://gerrit.osmocom.org/13052 )
Change subject: EDGE tests: remove no-op check ...................................................................... Patch Set 1: > maybe this is to present a unified interface of GPRS and EGPRS coding? Maybe > there are (future) cases where the return isn't envisioned as being const? Maybe so but I'm not sure that the envisioned future implementation will use headerType*() functions which expose rather low-level details like particular enum values. Hence I think it might be still beneficial to get rid of it now because there're no comments clarifying the actual intention. -- To view, visit https://gerrit.osmocom.org/13052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4 Gerrit-Change-Number: 13052 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2019 11:07:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
