dexter has posted comments on this change. ( https://gerrit.osmocom.org/13049 )
Change subject: AMR: add functions to convert between bw-efficient and octet-aligned ...................................................................... Patch Set 6: (1 comment) > Test failure might or might not be related to https://osmocom.org/issues/3812 > - simply re-triggering the test fixed it for me. Unfortunately I > haven't found a way to reproduce this reliably locally. Thanks for the notice, I have realized that there was a buffer overrun in the code, probably that was the issue. I have fixed that now. https://gerrit.osmocom.org/#/c/13049/3/src/amr.c File src/amr.c: https://gerrit.osmocom.org/#/c/13049/3/src/amr.c@68 PS3, Line 68: /*! Check if an AMR frame is octet aligned by looking at the padding bits. > those ar enwe public API functions, so they should have doxygen-style API > documentation, even if old […] Done -- To view, visit https://gerrit.osmocom.org/13049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b5a0fa644d8dbb1f04f9d7e35312683c7b3d196 Gerrit-Change-Number: 13049 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 07 Mar 2019 10:37:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
