dexter has posted comments on this change. ( https://gerrit.osmocom.org/13093 )
Change subject: codec_pref: purify S-Bits ...................................................................... Patch Set 1: > I guess this makes sure that the error path of the other patch is > never possible to trigger? In theory yes, but we should have a TTCN3 test that tries to make it fail. I am currently not sure what happens when the MSC tries to select 5 different rates separately for example. There are many variations possible. -- To view, visit https://gerrit.osmocom.org/13093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie52376b51fe07ed07056e8df2e9557293ff67a78 Gerrit-Change-Number: 13093 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2019 11:14:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
