Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13196 )
Change subject: Add IPA keep-alive FSM implementation ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c File src/input/ipa_keepalive.c: https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@126 PS2, Line 126: ifp->params.wait_for_resp, T_SEND_NEXT_PING); Are params correct or actually swapped? shouldn't be here ifp->params.interval and in ipa_ka_init ifp->params.wait_for_resp? https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@214 PS2, Line 214: fi = osmo_fsm_inst_alloc(&ipa_keepalive_fsm, ctx, NULL, LOGL_DEBUG, id); check against NULL and return -- To view, visit https://gerrit.osmocom.org/13196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2763da49a74de85046ac07d53592c89973314ca6 Gerrit-Change-Number: 13196 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 08 Mar 2019 22:46:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
