Max has posted comments on this change. ( https://gerrit.osmocom.org/13136 )
Change subject: vlr_subscr: use osmo_use_count ...................................................................... Patch Set 2: (1 comment) Not sure what's the status of libosmocore patch, but you can split this one into 2 patches: 1) update #define of macro wrappers with extra parameters 2) actually adding use_count bits and using extra parameters. That way patch will become significantly smaller (and hence easier to review) and the 1st part can be merged right away without waiting for libosmocore part. https://gerrit.osmocom.org/#/c/13136/2/include/osmocom/msc/vlr.h File include/osmocom/msc/vlr.h: https://gerrit.osmocom.org/#/c/13136/2/include/osmocom/msc/vlr.h@361 PS2, Line 361: #define vlr_subscr_find_by_tmsi(vlr, tmsi, USE) \ This change is pretty-much independent from use_count API? -- To view, visit https://gerrit.osmocom.org/13136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib06d030e8464abe415ff597d462ed40eeddef475 Gerrit-Change-Number: 13136 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 Mar 2019 15:04:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
