Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 )
Change subject: TBF: update MCS counters ...................................................................... Patch Set 1: (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/13243/1/src/tbf.h File src/tbf.h: https://gerrit.osmocom.org/#/c/13243/1/src/tbf.h@651 PS1, Line 651: void update_coding_scheme_counter_dl(enum CodingScheme cs); > Would be nice to have the enum named GprsCodingSCheme It includes both Gprs and Egprs coding schemes so I prefer smth more generic. > Can the class be dropped? Not yet unfortunately. Besides, I don't want to introduce changes which are neither immediate necessity nor convenience for the task at hand (fixing IA RO/TAI), and that class is used all over the place. -- To view, visit https://gerrit.osmocom.org/13243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I763136c2f356d63aa3d28d09c57fd5faf5336258 Gerrit-Change-Number: 13243 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:22:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
