Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13227 )

Change subject: incoming connect: don't crash if calling addr is missing
......................................................................

incoming connect: don't crash if calling addr is missing

The idea was to guard the logging, though actually that can handle a NULL ss7
quite well.

Change-Id: Ib028432b37a5c48b677bb21b869cc722575dce92
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 4b2c4ae..2ff5d80 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -122,7 +122,6 @@
        }

        ss7 = osmo_ss7_instance_find(msc->a.cs7_instance);
-       OSMO_ASSERT(ss7);
        LOGP(DMSC, LOGL_ERROR, "Unable to find MSC data under address: %s\n", 
osmo_sccp_addr_name(ss7, msc_addr));
        return NULL;
 }

--
To view, visit https://gerrit.osmocom.org/13227
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib028432b37a5c48b677bb21b869cc722575dce92
Gerrit-Change-Number: 13227
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>

Reply via email to