Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13319 )

Change subject: a_iface_bssap: add context information to log output
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c@167
PS2, Line 167:  /* Confirm that we managed to get the reset ack message
> That seems redundant: it'll be printed as part of the prefix anyway.
the point here was that the %s / osmo_sccp_addr_name() is redundant.  Not the 
enitre log line.  So please keep the log line, but remove the %s + 
osmo_sccp_addr_name from it.



--
To view, visit https://gerrit.osmocom.org/13319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I704954edc8677688fc7cccd2b23d2aff958ebf32
Gerrit-Change-Number: 13319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-CC: Max <msur...@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2019 15:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to