Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13339 )
Change subject: commands: correct case of a TLV tag (A5 => a5) ...................................................................... Patch Set 2: Code-Review+1 Looks good, but does it make sense to avoid this in general by using to_lower in the TLV class or is this too much work? -- To view, visit https://gerrit.osmocom.org/13339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Gerrit-Change-Number: 13339 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Kévin Redon <kre...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Mar 2019 16:59:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
