Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13340 )
Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py@540 PS2, Line 540: self._scc.sel_ctrl = "0004" #request an FCP You're overwriting the other sel_ctrl here, is that intended? Does this break other stuff? Or remove the line above? -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Kévin Redon <kre...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Mar 2019 17:02:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
