Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_sockaddr_str API ...................................................................... Patch Set 8: Code-Review-1 (1 comment) thanks for the rename. Let me incorporate and use this in tests just to make sure. https://gerrit.osmocom.org/#/c/13123/8/include/osmocom/core/sockaddr_str.h File include/osmocom/core/sockaddr_str.h: https://gerrit.osmocom.org/#/c/13123/8/include/osmocom/core/sockaddr_str.h@77 PS8, Line 77: int osmo_sockaddr_str_from_sockaddr(struct osmo_sockaddr_str *sockaddr_str, const struct sockaddr_storage *dst); whoops, the source argument is called dst here. same in my original patch. -- To view, visit https://gerrit.osmocom.org/13123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63 Gerrit-Change-Number: 13123 Gerrit-PatchSet: 8 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Assignee: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Sun, 24 Mar 2019 16:48:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes