Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13464 )
Change subject: MT-forwardSM Message Reference fix. ...................................................................... Patch Set 1: > there is still a risk of collision: imagine SMSC initiating a MT SMS with > e.g. 0xde, and at the same time the same subscriber initiates MO SMS with > 0xde! This would result in an unexpected behaviour as on the SMSC's side, as > on the subscriber's side. Hmm. Would it? I don't see how it affects the subscriber's side as the Message References between the subscriber and MSC are sort of private and allocated only by MSC. And the GSUP-server side should be responsible for mapping invokeIds (if it uses MAP) with message references then, right? I mean if message references for MO and MT coincide, then there is still a way to differentiate between them because GSUP messages are different for MOs and MTs. What do you think? I don't see yet what other resolution there could be... -- To view, visit https://gerrit.osmocom.org/13464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia50fd0e6c7ba7876522f49a00c55f8499c164331 Gerrit-Change-Number: 13464 Gerrit-PatchSet: 1 Gerrit-Owner: Mykola Shchetinin <myk...@pentonet.com> Gerrit-Assignee: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Mykola Shchetinin <myk...@pentonet.com> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 01 Apr 2019 09:26:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
