Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13392 )
Change subject: fsm: support graceful osmo_fsm_inst_term() cascades ...................................................................... Patch Set 4: (1 comment) (one stray remark...) https://gerrit.osmocom.org/#/c/13392/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13392/4//COMMIT_MSG@33 PS4, Line 33: Note: at least osmo-msc's msc_vlr_tests' expected output needs to be adjusted : after merging this, because of logging changes for FSM deallocations > this is *very* bad. […] The main cause is that the order of deallocation changes. Before, we took care to first deallocate the child before dispatching the parent_term_event. Now, to be safe, I have to deallocate after the parent_term_event instead. -- To view, visit https://gerrit.osmocom.org/13392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8eda67540a1cd444491beb7856b9fcd0a3143b18 Gerrit-Change-Number: 13392 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 02 Apr 2019 03:30:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
