Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13479 )
Change subject: USSD: fix routing to multiple MSC ...................................................................... Patch Set 8: (2 comments) Just a few final recommendations, looks fine to me ;) https://gerrit.osmocom.org/#/c/13479/8/src/hlr_ussd.c File src/hlr_ussd.c: https://gerrit.osmocom.org/#/c/13479/8/src/hlr_ussd.c@239 PS8, Line 239: for IMSI %s This is redundant, LOGPSS() does print IMSI. https://gerrit.osmocom.org/#/c/13479/8/src/hlr_ussd.c@248 PS8, Line 248: LOGP LOGPSS()? There will be no need to print "for subscriber %s...". -- To view, visit https://gerrit.osmocom.org/13479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3 Gerrit-Change-Number: 13479 Gerrit-PatchSet: 8 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Apr 2019 17:47:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
