Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13562 )
Change subject: smpp: Make libsmpp34 use talloc for its allocations ...................................................................... Patch Set 2: Hi Pau, Harald, > Was there some communication with the original author before you changed API > names? > This is confusing for reviewers and a bit rude imho, specially since you > didn't > explain your intention with this kind of change. There was no. For some reason, I thought that this change is also assigned to me... You're right, sorry for that. My intention was to make the symbol names a bit shorter, and a bit closer to what I remember from similar API of SQLite3 (where one can use SQLITE_CONFIG_MALLOC). Please let me know whether I should rollback to the previous version. -- To view, visit https://gerrit.osmocom.org/13562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2725ffab6a225813e65768735f01678e2022128 Gerrit-Change-Number: 13562 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 10 Apr 2019 14:03:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
