Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13628 )
Change subject: gbproxy: parse dtap GSM48_MT_GSM_DEACT_PDP_REQ|ACK ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13628/1/src/gprs/gprs_gb_parse.c File src/gprs/gprs_gb_parse.c: https://gerrit.osmocom.org/#/c/13628/1/src/gprs/gprs_gb_parse.c@390 PS1, Line 390: case GSM48_MT_GSM_DEACT_PDP_ACK: Since GSM48_MT_GSM_ACT_PDP_REQ extracts the apn to parse_ctx->apn_ie we could set parse_ctx->apn_ie{,_len} back to 0 here. I don't think it really matters, though. We shouldn't get any meaningful packets with apn set after a PDP deact ACK anyway. -- To view, visit https://gerrit.osmocom.org/13628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20bf4db8da746e0b994bfe3f8178188831b67ed3 Gerrit-Change-Number: 13628 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2019 11:57:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
