Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13172 )
Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/13172/5/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/13172/5/src/osmo-bsc/assignment_fsm.c@350 PS5, Line 350: here you forget to conn->assignment.requires_voice_stream = requires_voice_pref; and a voice call fails to get an actual RTP stream. With this line included, I tested voice calls to work fine again. -- To view, visit https://gerrit.osmocom.org/13172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7499c8c866ea3ff7b1327edb3615d003d927d3 Gerrit-Change-Number: 13172 Gerrit-PatchSet: 5 Gerrit-Owner: tnt <t...@246tnt.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: tnt <t...@246tnt.com> Gerrit-CC: Max <sur...@alumni.ntnu.no> Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Sun, 28 Apr 2019 10:43:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
