Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13894 )
Change subject: vlr: optionally send IMEI early to HLR ...................................................................... Patch Set 1: Code-Review+1 (1 comment) I would have simply moved the IMEI CHECK unconditionally to the start, but maybe that violates some GSM MAP related spec? Either way, I'm happy with this approach, aside from the minor comments below. https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@955 PS1, Line 955: event without effect > I guess if this happens, then we have a bug somewhere? I would rather > OSMO_ASSERT(0) here... […] There's two cases: 1) the event is permitted in in_event_mask of the state, but we don't handle it here. Then it's a bug of the code and the code is incomplete, hence we normally put a "default: OSMO_ASSERT(0)" here 2) the event is not permitted in in_event_mask of the state. In this case, the osmo_fsm core will already print a message about an 'unhandled event' and discard the event. So in either case, the logging here is not needed/intended. -- To view, visit https://gerrit.osmocom.org/13894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88283cad23793b475445d814ff49db534cb41244 Gerrit-Change-Number: 13894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 08 May 2019 06:46:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
