Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13723 )
Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence ...................................................................... Patch Set 5: > I would appreciate if you remove comparison [...] We also discussed this at OsmoDevCon with Harald, and as it turns out, modern compilers can perfectly optimize out this comparison (i.e. the cmp instruction), since it's a static function and the synch. sequences are defined as a static array. We've compiled OsmoBTS with clang-8 and checked the results using 'objdump -d -S'. However, it doesn't mean that I'm against removing the comparison. This is simply not the main problem at the moment. Thanks again for your comments and tips, the initial version of this change was much worse from performance point of view... -- To view, visit https://gerrit.osmocom.org/13723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6d27c6589965c8b59a6d2598a7c43fd860f284 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 16:47:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
