Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13744 )
Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/13744/7/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/13744/7/src/gprs/gprs_gmm.c@1618 PS7, Line 1618: : /* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not accepted by the : * network. Returns true if MS has active PDP contexts in pdp_status */ : bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t pdp_status_len) : { : size_t i; : for (i = 0; i < pdp_status_len; i++) : if (pdp_status[i] != 0) : return true; : > Can you rename it to pdp_status_has_active_nsapis? […] Done https://gerrit.osmocom.org/#/c/13744/7/src/gprs/gprs_gmm.c@1629 PS7, Line 1629: } : : /* Chapter 9.4.14: Routing area update request */ : static int gsm48_rx_gmm_ra_upd_req(struct sgsn_mm_ctx *mmctx, struct msgb *msg, : struct gprs_llc_llme *llme) : { : #ifndef PTMSI_ALLOC : struct sgsn_signal_data sig_data; : #endif : struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg); : uint8_t *cur = gh->data; : > Can you remove this function. […] Done https://gerrit.osmocom.org/#/c/13744/7/src/gprs/gprs_gmm.c@1935 PS7, Line 1935: (DMM, LOGL_INFO, "\n"); > do a llist_empty(.. […] Done -- To view, visit https://gerrit.osmocom.org/13744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If610cbef17c25ec44e65d4f1b2340d102c560437 Gerrit-Change-Number: 13744 Gerrit-PatchSet: 8 Gerrit-Owner: Mykola Shchetinin <myk...@pentonet.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Mykola Shchetinin <myk...@pentonet.com> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Fri, 10 May 2019 07:10:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
