Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13873 )
Change subject: smpl_buf: Move it to device/common and create libdevice_common.la ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13873/2/Transceiver52M/device/common/Makefile.am File Transceiver52M/device/common/Makefile.am: https://gerrit.osmocom.org/#/c/13873/2/Transceiver52M/device/common/Makefile.am@12 PS2, Line 12: > Cosmetic: tabs vs spaces? We use tabs in general. Hi Vadim, I tihnk you should tune down a bit on your cosmetic review comments. I happen to see quite many of them here in gerrit, and if it's only a line in a makefile, or only some "not perfect" alignment in a multi-line statement in C, I think we shouldn't spend too much time on it. -- To view, visit https://gerrit.osmocom.org/13873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I465ad0f6d5569bb3006d711c8fd0df14391fcf35 Gerrit-Change-Number: 13873 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Fri, 10 May 2019 10:52:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
