Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/13843 )
Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap ...................................................................... Patch Set 4: (1 comment) Looks good. Just found the minor style comment. Will do +2 after it. https://gerrit.osmocom.org/#/c/13843/4/openbsc/src/osmo-bsc_nat/bsc_nat.c File openbsc/src/osmo-bsc_nat/bsc_nat.c: https://gerrit.osmocom.org/#/c/13843/4/openbsc/src/osmo-bsc_nat/bsc_nat.c@1213 PS4, Line 1213: /* : * Optionally rewrite setup message. This can : * replace the msg and the parsed structure becomes : * invalid. Please update. The structure is now valid but pointers may dangle? -- To view, visit https://gerrit.osmocom.org/13843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66c44890952339f15131081e2f629a2824b6d3ba Gerrit-Change-Number: 13843 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Thu, 16 May 2019 13:33:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
