Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10170 )
Change subject: clear GPRS indicator in SI3 while PCU is disconnected ...................................................................... Patch Set 3: Code-Review-2 actually, this code gets it wrong. The SI3 manipulation must be done at every PCU connect/disconnect, not at the time the BSC sends the BCCH INFO. That step might only happen once on BTS boot/connect time, while PCU might come and go all day long (hopefully not) -- To view, visit https://gerrit.osmocom.org/10170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a6f5c636c0fe098ee31c280d4572a3f8122b44b Gerrit-Change-Number: 10170 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-CC: Max <sur...@alumni.ntnu.no> Gerrit-Comment-Date: Mon, 27 May 2019 20:40:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
