Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14287 )
Change subject: ggsn: Fix undefined behaviour shifting beyond sign bit ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14287/2/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/#/c/14287/2/ggsn/ggsn_vty.c@657 PS2, Line 657: UINT32_C Never seen that macro before, but it should be the same as: (uint32_t) 1 << i -- To view, visit https://gerrit.osmocom.org/14287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869 Gerrit-Change-Number: 14287 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 30 May 2019 16:31:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
