fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/14359 )

Change subject: vty: adjust config name for unit-id
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14359/1/src/common/vty.c
File src/common/vty.c:

https://gerrit.osmocom.org/#/c/14359/1/src/common/vty.c@425
PS1, Line 425: unit_id
Maybe we should rather keep dash?

Most commands here use it, so this would be more consistent.
This way OsmoBSC would need a similar patch.


https://gerrit.osmocom.org/#/c/14359/1/src/common/vty.c@446
PS1, Line 446:
ws



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14359
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ief6f23cc891a528d4295f7b0b85ff49bce299e8b
Gerrit-Change-Number: 14359
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Wild <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilira...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:34:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to