Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 )
Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn File library/TRXC_CodecPort.ttcn: https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn@31 PS2, Line 31: log("Rx TRXC message: ", oct2char(pin.msg)); > doesn't the IPL4asp_PT log that by itself? Or, if it doesn't, can't we > simply enable related loggin […] As far as this issue is concerned the existing logging was sufficient - it was just not obvious that it arrived at the wrong port. I don't think this change is necessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9 Gerrit-Change-Number: 14372 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 04 Jun 2019 15:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Harald Welte <lafo...@gnumonks.org> Gerrit-MessageType: comment
