fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14397 )
Change subject: gsm48_decode_bcd_number2: fix ENOSPC edge case ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/14397/2/tests/gsm0408/gsm0408_test.c File tests/gsm0408/gsm0408_test.c: https://gerrit.osmocom.org/#/c/14397/2/tests/gsm0408/gsm0408_test.c@739 PS2, Line 739: .dec_buf_lim = 4 Also, the actual strlen(dec_ascii) is 3. There is no truncation with 4. Exactly 3 reproduces the problem: the number is truncated to "12", while rc is 0. https://gerrit.osmocom.org/#/c/14397/2/tests/gsm0408/gsm0408_test.c@739 PS2, Line 739: .dec_buf_lim = 4 comma is missing https://gerrit.osmocom.org/#/c/14397/2/tests/gsm0408/gsm0408_test.c@740 PS2, Line 740: } comma is missing -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie05900aca50cc7fe8a45d17844dbfcd905fd82fe Gerrit-Change-Number: 14397 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jun 2019 08:31:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
