laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14407 )
Change subject: bsc: Introduce test TC_ctrl_location ...................................................................... Patch Set 1: Code-Review-1 I'm not quite sure why we would want to pass CTRL commands into the ConnHdlr. The ConnHdlr exists for each "subscriber connection", so we can have different ConnHdlr components, one for each subscriber connection. It makes sense to dispatch things like BSSAP, RSL dedicated channel/RLL, as well as MGCP to it, as all of those exist logically separate for each ConnHdlr. Hoewver, the CTRL commands are BTS-global and they should IMHO not be handled in a per-connection handler component. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3640f6889e3b6adc3b4601082f948543c64a2fe3 Gerrit-Change-Number: 14407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Sat, 08 Jun 2019 09:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
