laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 )
Change subject: hlr: f_vty_subscr_show(): add invert arg ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14401/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/14401/1/hlr/HLR_Tests.ttcn@297 PS1, Line 297: function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template charstring exp_ret, I think it's a bit odd to have a function called 'match' which then has an "invert" parameter. I would argue to simply add another function like f_vty_transceive_nomatch. Particluarly as in the end, all but two lines of the two functions are different anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I176d8fd2ee74e1eb7ac797f931cd6005d398740f Gerrit-Change-Number: 14401 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-Comment-Date: Sat, 08 Jun 2019 10:01:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment