fixeria has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/libosmocore/+/14426 )
Change subject: protocol/gsm_04_08.h: do not check if unsigned is positive
......................................................................
protocol/gsm_04_08.h: do not check if unsigned is positive
Change-Id: I6b486b52a3733d5fd5e8ba18acbc9374e2e8bd7e
---
M include/osmocom/gsm/protocol/gsm_04_08.h
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 16910c3..2be6ed3 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -719,7 +719,7 @@
*/
static inline void gsm48_barr_acc(struct gsm48_rach_control *rach_control,
unsigned int acc)
{
- OSMO_ASSERT(acc >= 0 && acc <= 15);
+ OSMO_ASSERT(acc <= 15);
if (acc >= 8)
rach_control->t2 |= (1 << (acc - 8));
else
@@ -733,7 +733,7 @@
*/
static inline void gsm48_allow_acc(struct gsm48_rach_control *rach_control,
unsigned int acc)
{
- OSMO_ASSERT(acc >= 0 && acc <= 15);
+ OSMO_ASSERT(acc <= 15);
if (acc >= 8)
rach_control->t2 &= ~(1 << (acc - 8));
else
@@ -748,7 +748,7 @@
*/
static inline bool gsm48_acc_is_barred(struct gsm48_rach_control
*rach_control, unsigned int acc)
{
- OSMO_ASSERT(acc >= 0 && acc <= 15);
+ OSMO_ASSERT(acc <= 15);
if (acc >= 8)
return (rach_control->t2 & (1 << (acc - 8))) != 0;
return (rach_control->t3 & (1 << (acc))) != 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14426
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6b486b52a3733d5fd5e8ba18acbc9374e2e8bd7e
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
