fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14430 )
Change subject: vty: command.c: Get rid of big indentation block ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14430/1/src/vty/command.c File src/vty/command.c: https://gerrit.osmocom.org/#/c/14430/1/src/vty/command.c@2317 PS1, Line 2317: if (argc >= CMD_ARGC_MAX) This condition would become unreachable after this change if varflag != 0. https://gerrit.osmocom.org/#/c/14430/1/src/vty/command.c@2463 PS1, Line 2463: if (argc >= CMD_ARGC_MAX) Same here. We can probably move it to the beginning of the loop. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibc1494014b1e77ce10950f7268a44d2d2091a6f2 Gerrit-Change-Number: 14430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 12 Jun 2019 18:13:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
