fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14472
Change subject: libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm ...................................................................... libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm Since [1] has been merged to libosmocore, it was discovered that the 'msc_a' FSM has a dummy 'allstate_action' handler assigned, but 'allstate_event_mask' is 0x00 at the same time. It basically doesn't make any sense, and moreover does cause warnings and build failures. [1] https://git.osmocom.org/libosmocore/commit/?id=b3f94eb39e19366c3458643ee329a73155d46ff8 [1] https://gerrit.osmocom.org/#/c/libosmocore/+/14361/ Change-Id: Ieb81b7a07ced1c40ba70d2adb0df68160ee62118 --- M src/libmsc/msc_a.c 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/14472/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index b311df3..bd69eed 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -809,16 +809,6 @@ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, fi); } -void msc_a_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) -{ - //struct msc_a *a = msc_a_fi_priv(fi); - switch (event) { - - default: - return; - } -} - void msc_a_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause) { struct msc_a *msc_a = msc_a_fi_priv(fi); @@ -991,9 +981,6 @@ .num_states = ARRAY_SIZE(msc_a_fsm_states), .log_subsys = DMSC, .event_names = msc_a_fsm_event_names, - .allstate_action = msc_a_fsm_allstate_action, - .allstate_event_mask = 0 - , .timer_cb = msc_a_fsm_timer_cb, .cleanup = msc_a_fsm_cleanup, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ieb81b7a07ced1c40ba70d2adb0df68160ee62118 Gerrit-Change-Number: 14472 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-MessageType: newchange
